google / google/yapf

dedent_closing_brackets not working for Annotations[]

Open
#1,200 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
14k
Forks
904
PR merge metrics
No merged PRs in 30d

Description

My config:
```init
[tool.yapf]
based_on_style = "google"
dedent_closing_brackets = true
coalesce_brackets = true
```

Generated diff:
```diff
+++ ./src/db/models/annotations/__init__.py (reformatted)
@@ -7,6 +7,8 @@
EmailAnnotation = Annotated[str, AfterValidator(validators.email_string)]
DomainAnnotation = Annotated[str, AfterValidator(validators.domain_name)]
NameAnnotation = Annotated[str, AfterValidator(validators.name_string)]
-DescriptionAnnotation = Annotated[str, AfterValidator(validators.description_string)]
-RoleCodeAnnotation = Annotated[int, AfterValidator(validators.not_negative_number)]
+DescriptionAnnotation = Annotated[str,
+ AfterValidator(validators.description_string)]
+RoleCodeAnnotation = Annotated[int,
+ AfterValidator(validators.not_negative_number)]
StrIdAnnotation = Annotated[str, AfterValidator(validators.string_id)]
```
I want to work this feature similar to how it works with functions:
```diff
- function(long_param_a, long_param_b, long_param_c)
+ function(
+ long_param_a,
+ long_param_b,
+ long_param_c,
+ long_param_d
+ )
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.