NodeInCycleConstraint and DifferenceConstraint should use node IDs rather than pointers
Open
bug
cleanup
estimate:S
scheduler
- Dominant language
- C++
- Stars
- 1.9k
- Forks
- 283
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 135
Description
Currently, the NodeInCycleConstraint and DifferenceConstraint passed into the scheduler use node pointers, which means that if a scheduling pass creates or destroys nodes, the pointers could be invalidated (or worse, the pointer could be silently reused). The correct way to handle this is to use node IDs instead.
Contributor guide
Assessment
This issue has not been assessed yet.