google / google/xls

NodeInCycleConstraint and DifferenceConstraint should use node IDs rather than pointers

Open
#938 0 comments 0 reactions 0 assignees View on GitHub
bug cleanup estimate:S scheduler
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Currently, the NodeInCycleConstraint and DifferenceConstraint passed into the scheduler use node pointers, which means that if a scheduling pass creates or destroys nodes, the pointers could be invalidated (or worse, the pointer could be silently reused). The correct way to handle this is to use node IDs instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.