google / google/xls

Separate package and module names from dslx source file names

Open
#893 2 comments 0 reactions 1 assignee Assigned to @richmckeever View on GitHub
dslx enhancement
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Currently during ir conversion, the dslx source file path may be used to create package and module names.

https://github.com/google/xls/blob/main/xls/dslx/ir_convert/ir_converter.cc#L3717
https://github.com/google/xls/blob/main/xls/dslx/ir_convert/ir_converter.cc#L3730

This means that dslx file names .x must be prefixed (before the dot) with valid dslx identifier names.

This issue is to relax this constraint so that dslx files can be named to be any valid filesystem name.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.