google / google/xls

[dslx] type info iteration order is nondeterministic

Open
#874 0 comments 0 reactions 0 assignees View on GitHub
dslx
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Right now to construct serialized type information for a module we traverse an unordered map, then sort by textual span start; however, when there's a tie on textual span start the order is still undetermined, need some criterion to make a total order.

Could traverse to number the AST in memory, but might be a little nicer if it could be done on the proto data instead of in-memory objects.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.