google / google/xls

Rename FunctionBase to Routine

Open
#784 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

FunctionBase is a clunky name and hard to use in comments/documentation (e.g.: we currently say things like `foo accepts a function/proc/block` rather than `foo accepts a FunctionBase` because we don't want comments to be too tightly coupled to non-user friendly names). We could rename FunctionBase to Routine, and then explain in the documentation that functions/procs/blocks are all types of routines. A function/proc can then be referred to as a schedulable routine.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.