google / google/xls

DSLX: Remove proc initial value specification from the BUILD flow

Open
#681 4 comments 0 reactions 0 assignees View on GitHub
dslx
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

To convert a DSLX proc into IR, we need to specify an initial value for the proc's state. That specification is currently done in the BUILD file, which is fragile. Consider the following example:
```
xls_dslx_opt_ir(
name = "aes_128_ctr",
dslx_top = "aes_128_ctr",
ir_conv_args = {
"top_proc_initial_state": "'(0, (0, [0, 0, 0, 0], 0, 0), 0, 0)'",
},
library = ":aes_128_ctr_dslx",
)
```

First of all, this is simply hard to read or parse for human eyes, and secondly, it's hard to maintain: what if the state changes for aes_128_ctr? We need to figure out some way to remove initial values from this flow.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.