google / google/xls

DSLX: Bad error message on malformed `match` expr

Open
#677 0 comments 0 reactions 0 assignees View on GitHub
bug dslx estimate:XS
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

I wrote bad code like the following:
```
let new_step = match (state.step, aad_blocks_left == u32:0, ctxt_blocks_left == u32:0) {
( Step::RECV_AAD, false) => Step::RECV_AAD,
...
};
```

Notice that the number of fields in the matcher differs from that in the match header. I'd expect some "bad number of whatever" error message, but instead I got:

```
E0824 09:51:56.399187 2649910 run_routines.cc:332] Internal error: INTERNAL: Could not find type for number: false
```

Should be fixed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.