google / google/xls

Make Run in JIT wrapper note only last value is mutated outparam

Open
#444 0 comments 0 reactions 0 assignees View on GitHub
jit
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

The other parameters passed to `Run()` that the JIT wrapper creates -- except for the last -- are effectively const, but we need to have the last parameter be an effective "outparam" since the idea is to avoid allocating things to provide back to the caller (that's why they're the packed types). See relatedly https://github.com/google/xls/issues/416#issuecomment-857290800

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.