google / google/xls

High bit dimension warning is brittle.

Open
#4,260 0 comments 0 reactions 0 assignees View on GitHub
dslx
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

You are supposed to get a warning if you use a value with bit 31 set as a dimension. However, currently this will only trigger where array type unification is actually required and cannot be short-circuited.

Fuzz test domain specs, for example, are currently "exempt" from the warning due to happenstance (unification gets short circuited), but any change that starts to force unification would make fuzz domains like `u32:0..0xffffffff` trigger this warning. It's unclear if that would then be desired or a bug. Such domains can lower and work perfectly fine.

We need to shore up this warning and make it more guaranteed if we really want it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.