google / google/xls

`dslx_jit_wrapper` needs to anonymous namespace ir_text to avoid ODR violations?

Open
#408 1 comment 0 reactions 0 assignees View on GitHub
jit
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Noticed the source files all have `ir_text[]` in the xls namespace -- even though it's `constexpr char char ir_text[]` still can cause ODR violations I presume (and these I imagine would be confusing since we'd JIT the wrong thing)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.