google / google/xls

Stop using Module::FindNode() or change TIv2 to ensure fabricated nodes never collide by span with source nodes.

Open
#3,930 0 comments 0 reactions 1 assignee Claimed by @richmckeever View on GitHub
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

The use of FindNode(), for example in type_info_to_proto.cc, is currently unreliable in some edge cases, due to collisions with fabricated nodes which are mapped to the same span as nodes appearing in the source.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.