google / google/xls

zstd library dependency still needed ?

Open
#3,708 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

There is a dependency on zstd https://github.com/google/xls/blob/main/dependency_support/load_external.bzl#L62-L73

I was considering adding the additional targets in our [BUILD file for zstd](https://github.com/google/xls/blob/main/dependency_support/com_github_facebook_zstd/bundled.BUILD.bazel) and upstreaming it to the BZR version https://registry.bazel.build/modules/zstd ...

However, right now it looks like it is not referenced anywhere in our BUILD files, so maybe we don't need this anymore ? Is all the zstd testing done using riegeli ?

I might be wrong though, there is a pending PR https://github.com/google/xls/pull/3636 so maybe that needs that dependency.
Tagging @magancarz (author of that PR) and @proppy (reviewer?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.