google / google/xls

Resurrect the checks from xls/dslx/diagnostics:maybe_explain_error

Open
#3,595 0 comments 0 reactions 1 assignee Claimed by @richmckeever View on GitHub
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

This extra error message logic is effectively dead code with TIv2 turned on. Taking it out of the loop was not intentional; we didn't realize it existed when building TIv2. We are going to remove it for the time being because it's nontrivial to wean the test off of its use of TIv1 internals. We should resurrect it or move the functionality somewhere else.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.