google / google/xls

Support array and tuple types in AbstractEvaluator/QueryEngine

Open
#356 0 comments 0 reactions 0 assignees View on GitHub
formal ir optimizer
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Right now the abstractevaluator only supports bits types. array and tuple types are basically ignored. It should be expanded to handle these types. Basically the fundamental datatype held for each node needs to be changed from AbstractEvaluator::Vector to a LeafTypeTree. See [xls/data_structures/leaf_type_tree.h](https://github.com/google/xls/blob/main/xls/data_structures/leaf_type_tree.h). A LeafTypeTree is a container which holds an element for each leaf in a XLS type.

One complication is users like z3 which may have their own special array types which we want may to use.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.