google / google/xls

xls_dslx_generate_cpp_type_files does not actually support deps

Open
#3,045 1 comment 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

**Describe the bug**
If the target DSLX src file depend on types (not constants) from its deps, the generated C++ will be invalid.

You will get `error: use of undeclared identifier ''`.

**Expected behavior**
There should be a mechanism to include generated headers from dependencies.

**Additional context**
Related: https://github.com/google/xls/issues/1610 would expose this problem more heavily. To date, we've limited the impact of this bug because commonly its constants from DSLX dependencies that are referenced. These are just turned into literals in the generated C++.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.