google / google/xls

gather_design_stats should not overwrite design stats when provided when multiple logs

Open
#2,054 0 comments 0 reactions 0 assignees View on GitHub
bug ux
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

**Describe the bug**
Not sure if this is the intended behavior, but it seems that `gather_design_stats` always overwrite the same design stats entry when provided with multiple log files.

**To Reproduce**
Run `gather_design_stats` with multiple files, notice that only the last of the provided log files is represented in the resulting proto.

**Expected behavior**
Either of the following behavior would be desirable instead:
- an error when providing more than one log files
- an average of all the metrics from the provided designs (assuming they all refer to the same design)
- a flag to support more than one design stats (and write the resulting data to a repeated proto or a https://github.com/google/riegeli file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.