google / google/xls

Assertions (and their exclusive inputs) should be guarded by `ifdefs

Open
#1,942 1 comment 0 reactions 0 assignees View on GitHub
codegen
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Our assertions should be guarded by `` `ifdef `` guards. This allows users to easily disable assertions without a recompile and also prevents assertions from being visible to synthesis- I believe yosys in particular can leave in stuff that causes problems for openroad if assertions aren't stripped.

Ideally, we'd also guard all the wires/regs that only feed assertions (or other wires/regs that only feed assertions) in those same guards to avoid "value not read" issues.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.