google / google/xls

[enhancement][DSLX:LSP] Language server could save all "crashes"

Open
#1,934 0 comments 0 reactions 0 assignees View on GitHub
dslx:lsp enhancement
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

### What's hard to do? (limit 100 words)

If there's a XLS_RET_CHECK that happens for some intermediate buffer state it'd be great to have a dump of the language server that caused the internal error to occur.

Because we don't have this, we can encounter transient issues that are hard to recover the input stimulus for.

### Current best alternative workaround (limit 100 words)

Be very careful when making edits or very cognizant of when an internal error happens in the language server.

### Your view of the "best case XLS enhancement" (limit 100 words)

We get something like a flag `--dump_internal_errors_to=/tmp/dir/` where it can dump language server state that exhibits the error and maybe a tool that helps us replay those for reproduction.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.