google / google/xls

[enhancement][DSLX] Support `..=` inclusive range so pattern matches can use inclusive max value

Open
#1,904 4 comments 0 reactions 0 assignees View on GitHub
dslx enhancement
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

### What's hard to do? (limit 100 words)

Right now you can't do a pattern easily like: `s8:0..s8:127 => ` with an inclusive maximum value for a type because the 127 is excluded and the type is incapable of expression 128. Rust has `..=` to help with this.

### Current best alternative workaround (limit 100 words)

Add another pattern to match arm with | like `s8:0..s8:127 | s8:127 => `

### Your view of the "best case XLS enhancement" (limit 100 words)

We add `..=` support to pattern ranges as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.