google / google/xls

cc_xls_ir_jit_wrapper fails to resolve entrypoints w/ name conflicts

Open
#1,877 1 comment 0 reactions 1 assignee Claimed by @proppy View on GitHub
build jit
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

**Describe the bug**

When attempting to use `cc_xls_ir_jit_wrapper` w/ https://github.com/google/xls/tree/main/xls/examples/matmul_4x4, the toolchain currently fails to resolve the block IR entrypoint w/ the following error:
```
More than one instance with name: __matmul_4x4__matmul_4x4_0_next
```

This seems to be due the block IR containing a `proc` and `block` w/ the same name:
```
functions: [], procs: [__matmul_4x4__matmul_4x4_0_next, __matmul_4x4__matmul_4x4__matmul_0__node_0_next, __matmul_4x4__matmul_4x4__matmul_0__node_1_next, __matmul_4x4__matmul_4x4__matmul_0__node_2_next, __matmul_4x4__matmul_4x4__matmul_0__node_3_next, __matmul_4x4__matmul_4x4__matmul_0__node_4_next, __matmul_4x4__matmul_4x4__matmul_0__node_5_next, __matmul_4x4__matmul_4x4__matmul_0__node_6_next, __matmul_4x4__matmul_4x4__matmul_0__node_7_next, __matmul_4x4__matmul_4x4__matmul_0__node_8_next, __matmul_4x4__matmul_4x4__matmul_0__node_9_next, __matmul_4x4__matmul_4x4__matmul_0__node_10_next, __matmul_4x4__matmul_4x4__matmul_0__node_11_next, __matmul_4x4__matmul_4x4__matmul_0__node_12_next, __matmul_4x4__matmul_4x4__matmul_0__node_13_next, __matmul_4x4__matmul_4x4__matmul_0__node_14_next, __matmul_4x4__matmul_4x4__matmul_0__node_15_next, __matmul_4x4__matmul_4x4__matmul_0__4_4_next], blocks: [__matmul_4x4__matmul_4x4_0_next]
```

**Expected behavior**

Since `cc_xls_ir_jit_wrapper` also includes a mandatory `wrapper_type` attr, it should be able to disambiguish and resolve the right entrypoint.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.