google / google/xls

[enhancement] Decouple Regression Model validation from building a regression model

Open
#1,593 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

### What's hard to do? (limit 100 words)

Currently, we do k-fold validation every time we call the constructor [1] of RegressionEstimator. The k-fold validation is private within the class. However, there's a need for using the validator without using the model [2], which calls the EstimatorModel to do k-fold validation. This is confusing.

[1] https://github.com/google/xls/blob/6497966ee820e29c7b86552511aaddb2a54430af/xls/estimators/delay_model/delay_model.py#L355-L360
[2] https://github.com/google/xls/blob/6497966ee820e29c7b86552511aaddb2a54430af/xls/contrib/integrator/area_model/area_characterization_client_main.py#L405-L406

### Current best alternative workaround (limit 100 words)

N/A

### Your view of the "best case XLS enhancement" (limit 100 words)

Decouple RegressionEstimator validation from constructor, allowing validation without using the model.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.