google / google/xls

Use std::byte for JIT buffers/views/associated helpers

Open
#1,251 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

We currently use `uint8_t*` for JIT input/output buffers. The unpacked views will `reinterpret_cast` `uint8_t*`, which could be (although is not on our supported platforms) UB. `std::byte` would be safer. This touches not just the JIT interface and views, but also a lot of associated helpers, e.g. for packing/unpacking, testing, etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.