google / google/xls

absl:: and benchmark:: flags seem to fight each other

Open
#1,150 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 12h
Merged PRs (30d)
130

Description

Having benchmark:: and gtest tests together seems to produce some odd issues where the benchmark:: flags seem to get eaten by absl. This might be some issue with our configuration of these libraries.

Currently we work around this by using absl to parse the benchmark_filter flag and pass that down manually.

Take a look and try to remove this workaround at some point.

Contributor guide

Open the contributing guide

Research direction

Start by locating the test configuration and the workaround that uses absl to parse benchmark_filter and pass it manually. Investigate how benchmark:: and absl flags are initialized when benchmark and gtest tests run together. Done means the workaround is removed and benchmark flags continue to work correctly in the combined test setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.