google / google/xls

Consider using Bazel 'Args'

Open
#1,144 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

If possible it's often better to use Bazel's Args construct to generate flags for binaries. It has automatic conversions for files and the like.

https://bazel.build/rules/lib/builtins/Args

This originated from a comment by @QuantamHD, considering args processing as shown below from https://github.com/google/xls/blob/main/xls/build_rules/xls_codegen_rules.bzl:

```
final_args += " --output_block_ir_path={}".format(block_ir_file.path)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.