google / google/xls

[DSLX:ast] Proc config functions require a tuple literal as the last statement

Open
#1,124 0 comments 0 reactions 0 assignees View on GitHub
cleanup dslx estimate:M
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Proc config functions require a tuple literal as the last statement as the implementation currently exists. However, some procs may have `spawn` statements, for example, as their last statement, with a trailing semicolon.

Instead of requiring there literally be a tuple AST node as the last statement that we have to synthesize for later code to rely on, it'd be better if we e.g. did analysis and kept appropriate metadata after typechecking. TL;DR: AST munging bad.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.