google / google/xls

[DSLX:cleanup] Break parse errors / error position extraction out into own translation unit

Open
#1,099 0 comments 0 reactions 0 assignees View on GitHub
cleanup dslx estimate:XS
Dominant language
C++
Stars
1.9k
Forks
283
Avg merge
2d 10h
Merged PRs (30d)
135

Description

Or maybe we can tack error position data on into the `absl::Status` metadata map even.

Right now this error functionality is kind of all splatted into `bindings.h` and friends, it should be nicely carved out similar to how `errors.h` is done, though that one drags in `ConcreteType` so that it can create type errors, so to avoid circular deps we may need to make a separate translation unit instead of adding the parse errors to that one.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.