google / google/wuffs

Go modules in conflict with wuffRoot

Open
#21 17 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
4.8k
Forks
145
Avg merge
11h 48m
Merged PRs (30d)
1

Description

Recently, go module was introduced, which sounds like the way to go (pardon the pun) with golang.

However this is in conflict with wuff's design, which assumes some source artifacts are available through `$GOPATH/src/github.com/wuffs`.

For example, `wuffs gen` is [hardcoded](https://github.com/google/wuffs/blob/master/cmd/wuffs/gen.go#L145) to consume files from wuffs source root.

A more reasonable design would be not to depend on the wuffs source dir in the modules era, but to package required resources in the executable, and accept path for the sources to generate.

Even if `wuffsRoot` is still deemed necessary, I think we should explicitly copy the required resources to `$GOPATH/src` in `build-all.sh`, in order to have a clean copy of cloned `wuffs` simply work.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.