google / google/webcrypto.dart

Upgrade BoringSSL

Open
#111 10 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Dart
Stars
116
Forks
110
Avg merge
6d 8h
Merged PRs (30d)
9

Description

We need to upgrade BoringSSL, however, their build scripts have changed a bit. In particular how ASM files are added, so we might need to make some changes.

The logic is in:
https://github.com/google/webcrypto.dart/blob/master/tool/update-boringssl.py

We need to bump `BORINGSSL_REVISION`.

And then fix our build script generator logic, since `asm_outputs` parameter isn't give to [`WriteFiles`](https://github.com/google/webcrypto.dart/blob/master/tool/update-boringssl.py#L135) anymore.

I tried playing with this, but we need to do more than simple remove the `asm_outputs` parameter.

--------

There is some documentation in: https://boringssl.googlesource.com/boringssl/+/refs/heads/master/INCORPORATING.md

The rest is reading BoringSSL code and build system :rofl:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.