google / google/volley

Volley doesn't ensure that the "timeout" has elapsed before retrying

Open
#80 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.4k
Forks
751
Avg merge
8h 49m
Merged PRs (30d)
2

Description

The property "getCurrentTimeout" in RetryPolicy is used only to set a timeout on the HTTP connection. If the server returns an error code rapidly, the request engine will retry immediately.

There is no enforcement that the value provided by "getCurrentTimeout" has elapsed, which caught me quite offguard. This will, for example, cause me to drain battery if I set a high maxRetries with a high timeout, thinking that the interval between requests would respect the timeout / backoff multiplier.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.