google / google/volley

Update Request#parseNetworkResponse javadoc to disallow returning null

Open
#322 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.4k
Forks
751
Avg merge
8h 49m
Merged PRs (30d)
2

Description

Request#parseNetworkResponse claims it's okay to return null if a response can't be parsed. In reality, it seems like this would almost guarantee an NPE either in CacheDispatcher or ExecutorDelivery, so unless someone has an entirely custom ResponseDelivery, they probably already are returning Response.error rather than null. We should verify this and consider updating the Javadoc accordingly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.