google / google/volley

Turn off default caching of POST requests

Open
#190 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.4k
Forks
751
Avg merge
8h 49m
Merged PRs (30d)
2

Description

Original context: https://github.com/google/volley/issues/154

Volley caches POST requests by default. But the semantics for doing so are pretty broken - the request body is not included in the default cache key and POST requests are always supposed to hit the origin server according to the RFC - the cached response should only be used for subsequent GET requests in certain scenarios (e.g. https://www.mnot.net/blog/2012/09/24/caching_POST).

Unless/until we have an actual implementation of a working POST cache by default, we should disable this functionality and leave it up to clients to implement or turn on if it's really what they want.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.