google / google/ts-bridge

Add a better approach for error handling in Cloud Build docker pull

Open
#67 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
56
Forks
20
PR merge metrics
No merged PRs in 30d

Description

` args: ['-c', 'docker pull gcr.io/$PROJECT_ID/ts-bridge:latest || exit 0']`
This step (originally copied from https://cloud.google.com/cloud-build/docs/speeding-up-builds#using_a_cached_docker_image) will mask all errors from docker pull, not just when image doesn't exist. Consider using a more optimal approach which can parse the output from docker pull to handle errors better.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.