google / google/trillian

Bump golangci-lint and remove //nolint comments in experimental/batchmap/cmd/verify/verify.go

Open
#2,801 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
Go
Stars
3.7k
Forks
465
Avg merge
2d 16h
Merged PRs (30d)
5

Description

#2787 migrated Trillian to use `klog`. At the time, `golangci-lint`'s `staticcheck` did not know that `klog.Exit/Fatal` would not return and so threw false +ve lint checks during presubmit which were suppressed with `nolint` comments.

A fix has been sent which enlightens the lint checker, so once that fix has made it into a `golangci-lint` release (v1.48.0 did not contain it) we should bump the version used in our presubmits and remove the `//nolint` comments in [experimental/batchmap/cmd/verify/verify.go](https://github.com/google/trillian/pull/2787/files#diff-20e238926020c0e122f93aa474068b10dfcc62458920d5c5c1adfe7547a17e3bR102-R106)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.