google / google/trillian

strip out unused and unneeded code

Open
#2,245 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
Go
Stars
3.7k
Forks
465
Avg merge
2d 16h
Merged PRs (30d)
5

Description

A number of APIs (both external and internal) add burden to storage implementers, without bringing much benefits.

For example, `QueueLeaves` is complex to implement correctly, due to being a batching API with partial failure, but in practice, there are possibly no need for it, and due to the implementation complexity, is very unlikely to provide any performance benefit over using `QueueLeaf` (the non-batch version of this API) multiple times (potentially concurrently), say, and this both leaves the user in better control over what happens in the partial failure cases, and removes complexity of implementation (and the inevitable bugs that it brings).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.