google / google/trillian-examples

Don't pass secrets via flags

Open
#662 0 comments 0 reactions 1 assignee Claimed by @mhutchinson View on GitHub
enhancement
Dominant language
Go
Stars
176
Forks
68
Avg merge
13h 35m
Merged PRs (30d)
4

Description

Looking at `witness/golang/omniwitness/monolith/monolith.go`, we realized that it takes the private key material via flags. This is a security risk as anyone on the same machine could get this via `ps`.

We should swap this over to use env variables or a file, or something. And also review other main files to make sure there aren't others like this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.