google / google/transit

How is continuous_pickup/continuous_drop_off forbid language interpreted? Should it be adjusted to explicitly allow values of `1`?

Open
#507 3 comments 0 reactions 0 assignees View on GitHub
Discussion Period GTFS Schedule GTFS-Flex Status: Stale
Dominant language
No language data
Stars
1.1k
Forks
225
Avg merge
7d 17h
Merged PRs (30d)
3

Description

### Introduce yourself

Weston Shippy, Trillium

### Ask a question

Currently the restriction reads: "**Forbidden** if `stop_times.start_pickup_drop_off_window` or `stop_times.end_pickup_drop_off_window` are defined..."

Does this mean *any* presence of this field is forbidden if the above conditions are met, regardless of the specific value?

I can't think of why we would want to forbid an explicit value of "not available" when that's implicitly what is being stated by this restriction. Should it be changed to match the spirit of `stop_times.pickup_type/drop_off_type`? Like so:

"Any `continuous_pickup`/`continuous_drop_off` value other than `1` or empty is **forbidden** if `start_pickup_drop_off_window` or `end_pickup_drop_off_window` are defined..."

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.