google / google/testrun

TLS "certificate could not be validated" clarification in report

Open
#1,081 10 comments 0 reactions 1 assignee Claimed by @MariusBaldovin View on GitHub
test
Dominant language
Python
Stars
56
Forks
20
Avg merge
15h 54m
Merged PRs (30d)
12

Description

**Describe the bug**
I believe the [device](https://multitech.com/product/conduit-model-mtcdt-l4e1-europe-uk/) to which the below report pertains does not support/offer TLS 1.3.

![Image](https://github.com/user-attachments/assets/a7c9b879-0461-4093-995d-b4a480e91aa3)

The text "certificate could not be validated" implies that there was a certificate, but it could not be validated _for some reason_ (issue with the cert/issue with the cert chain/issue with Testrun itself/etc.), as opposed to the fact that TLS 1.3 is not supported and/or a certificate was not presented as a result.

**Expected behavior**
If a service doesn't support/offer TLS 1.3, this should be stated as such, to remove any ambiguity over whether a certificate was presented.

**Error logs**
[multitech.zip](https://github.com/user-attachments/files/18558154/multitech.zip)

**Environment (please provide the following information about your setup):**
- Version: 2.1
- Additional hardware (network adapters)

**Additional context**
Only modifications from official 2.1 release are as below.
- resources/test_packs/qualification.json (Set tests to excluded/recommended/informational as appropriate)
- resources/devices/device_profile.json (Add custom questions)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.