google / google/tcmalloc

`GetStatsTest.Parameters` Failure

Open
#164 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.3k
Forks
570
Avg merge
23h 43m
Merged PRs (30d)
172

Description

## Background
I want to try tcmalloc per-cpu cache & hpaa with TensorFlow. gperftools tcmalloc so is distributed as a yum package so I didn't have to build it.

## Setup
I read through the platform & quick start documentation and tried to build google's tcmalloc from source. I'm on Cent OS 7.4 kernel 5.4 with devtoolset-9 (gcc 9.3.1), python 3.7 & bazel 5.3.0. I can build tensorflow successfully so I don't suspect general issues with my setup.

## Issue
`GetStatsTest.Parameters` test fails. Spot checking other failures, I see the only failure is related to stats like `GetStatsLowLevel`. What does this failure imply?

Build:
```
Executed 307 out of 310 tests: 290 tests pass and 20 fail locally.
INFO: Build completed, 20 tests FAILED, 2350 total actions
```

`GetStatsTest.Parameters` Failure:
```
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //tcmalloc/testing:get_stats_test
-----------------------------------------------------------------------------
Running main() from gmock_main.cc
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from GetStatsTest
[ RUN ] GetStatsTest.Pbtxt
[ OK ] GetStatsTest.Pbtxt (22 ms)
[ RUN ] GetStatsTest.Parameters
tcmalloc/testing/get_stats_test.cc:105: Failure
Value of: buf
Expected: has substring "PARAMETER hpaa_subrelease 0"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:107: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_guarded_sample_parameter -1"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:109: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_per_cpu_caches 0"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:110: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_max_per_cpu_cache_size -1"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:112: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_max_total_thread_cache_bytes -1"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:115: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_skip_subrelease_interval 1s"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:146: Failure
Value of: buf
Expected: has substring "PARAMETER hpaa_subrelease 1"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:148: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_guarded_sample_parameter 50"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:150: Failure
Value of: buf
Expected: has substring "PARAMETER desired_usage_limit_bytes 18446744073709551615"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:154: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_per_cpu_caches 1"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:155: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_max_per_cpu_cache_size 3145728"
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:157: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_max_total_thread_cache_bytes 4194304"
Actual: "" (of type std::string)
Actual: "" (of type std::string)
tcmalloc/testing/get_stats_test.cc:160: Failure
Value of: buf
Expected: has substring "PARAMETER tcmalloc_skip_subrelease_interval 1m0.125s"
Actual: "" (of type std::string)
[ FAILED ] GetStatsTest.Parameters (35 ms)
[----------] 2 tests from GetStatsTest (58 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (58 ms total)
[ PASSED ] 1 test.
[ FAILED ] 1 test, listed below:
[ FAILED ] GetStatsTest.Parameters

1 FAILED TEST
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.