google / google/styleguide

jsguide: Please verify - MyClass.RETRY_COUNT

Open
#595 0 comments 0 reactions 0 assignees View on GitHub
lang:js question
Dominant language
HTML
Stars
39.6k
Forks
12.9k
Avg merge
42m
Merged PRs (30d)
15

Description

Please verify if MyClass.RETRY_COUNT is correct

https://google.github.io/styleguide/jsguide.html#jsdoc-property-comments

MyClass.RETRY_COUNT = 33;

- Is the above conflicting the below?

https://google.github.io/styleguide/jsguide.html#features-classes-fields

"Set all of a concrete object’s fields (i.e. all properties other than methods) in the constructor."

- Or is this a bug/ were you intending to export as below?
exports.RETRY_COUNT = 33;
instead of
MyClass.RETRY_COUNT = 33;

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.