google / google/slo-generator

🐛 [BUG] - Datadog exporter - Custom metrics quota

Open
#330 2 comments 0 reactions 1 assignee Claimed by @lvaylet View on GitHub
bug triage
Dominant language
Python
Stars
564
Forks
88
PR merge metrics
No merged PRs in 30d

Description

### SLO Generator Version

v2.3.3

### Python Version

3+

### What happened?

Hello everyone,

It look like the way you export data to Datadog is a little bit weird: the metrics events_count export data in label instead of value.

Example:
> INFO - test-slo | 28 days | SLI: 99.9954 % | SLO: 99.95 % | Gap: +0.05 % | BR: 0.1 / 1.0 | Alert: 0 | Good: 8868457 | Bad: 406

Will give the following metric
`events_count{good_events_count: 8868457,bad_events_count: 406,... }`

![image](https://user-images.githubusercontent.com/528345/218135138-7e2e4cc2-4452-4d3e-92cd-dba325de4103.png)

The issue with this implementation is that having a big granularity in label will consume all custom metrics quota.

### What did you expect?

I expected to have only 2 custom metrics by default

events_count{type: bad_event, ...} 406
events_count{type: good_event, ...} 8868457

### Screenshots

```bash
![DESCRIPTION](LINK.png)
```

### Relevant log output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.