google / google/slo-generator

Refactor duplicate code in Cloud Monitoring backends

Open
#268 1 comment 0 reactions 1 assignee Claimed by @lvaylet View on GitHub
invalid p/cloud_monitoring p/cloud_monitoring_mql refactor
Dominant language
Python
Stars
564
Forks
88
PR merge metrics
No merged PRs in 30d

Description

As highlighted by the `# pylint: disable=duplicate-code` comments, there is duplicate code in `slo_generator/backends/cloud_monitoring.py` and `slo_generator/backends/cloud_monitoring_mql.py`.

Refactor any duplicate code in a separate utils or helpers file, then remove these comments and confirm `make lint` completes successfully.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.