google / google/site-kit-wp

Set `linker` object in `gtag` within the Ads tag

Open
#9,947 1 comment 0 reactions 0 assignees View on GitHub
Module: Ads P2 PHP Type: Enhancement
Dominant language
JavaScript
Stars
1.4k
Forks
384
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

[Unlike Analytics](https://github.com/google/site-kit-wp/blob/0db6c72b707829d5bf2808db358acc91da30f6a7/includes/Modules/Analytics_4/Web_Tag.php#L141-L145), the Ads module does not set a linker object in `gtag` within its tag. This should be addressed in such a way so that when both Analytics and Ads modules are connected, only one `linker` object is set.

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start by comparing the Ads tag with includes/Modules/Analytics_4/Web_Tag.php, especially the referenced gtag linker setup. Trace how both module tags are emitted and verify that the Ads tag sets the linker object without producing duplicate linker objects when Analytics and Ads are connected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.