google / google/site-kit-wp

"Reset sharing permissions" is only applicable to modules owned by the administrator resetting

Open
#9,638 1 comment 0 reactions 0 assignees View on GitHub
Type: Bug Type: Support
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Bug Description

When using dashboard sharing, if there are modules shared by different administrators, the "Reset sharing permissions" CTA will only reset permissions for the administrator selecting that option. It won't reset permissions for modules not owned by that administrator. This can cause issues as the other administrator may not longer be active, or their WordPress account was removed, leaving a message to "Contact managing user" when that user no longer exists.

![Image](https://github.com/user-attachments/assets/1cd180cf-4c7b-43b4-b579-03333032ebdb)

To address this, considering making the "Reset sharing permissions" option applicable to all modules, even those not owned by the user resetting.

## Steps to reproduce

1. Set up SK on a site with only Search Console active from a WordPress administrator account (adminA)
2. Login with a different WordPress administrator account (adminB). Set up Site Kit as a secondary user and connect the Google Analytics or AdSense module. After doing so, grant sharing permissions to other users via [Dashboard Sharing](https://sitekit.withgoogle.com/documentation/using-site-kit/dashboard-sharing/).
3. Log back into the site from the original administrator account (adminA).
4. Share the Search Console module (so the option to "Reset Sharing Permissions" appears
5. Use the CTA to "Reset Sharing Permissions"
6. Only the Search Console module sharing permissions are reset, and not GA.

**Note**: A fix here would mean we can also close #9617

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the dashboard-sharing flow in the issue with two WordPress administrator accounts, then trace the "Reset sharing permissions" CTA and how it selects modules. The fix is done when resetting from one administrator also resets sharing permissions for modules owned by other administrators, including Search Console and Analytics.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.