No option to reset sharing permissions or recover a module if owner no longer exists
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 384
- Avg merge
- 4d 14h
- Merged PRs (30d)
- 77
Description
Bug Description
When performing some Dashboard Sharing checks, I ran into an issue whereby if one administrator who the module owner no longer exists, module recovery no longer occurs. This occurred when the Google account associated with module owner (which was a secondary administrator user) may have been used at some stage as the primary user (ie. The primary user/Site Kit owner, was changed by disconnecting and connecting once more).
Further testing ongoing, with steps to reproduce to be added.
Steps to reproduce
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Screenshots
Additional Context
- SK 1.139.0
- Potential bug, discovered during testing related to a support topic
- UPDATE: Reset sharing permissions does appear if you apply DS sharing options for other modules. This however, can't be used as a workaround as resetting will only reset modules owner by the user resetting.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the problem through the Dashboard Sharing checks described in the issue, using the reported Site Kit 1.139.0 setup with a deleted module owner. Trace the module recovery and reset-sharing-permissions paths; done means recovery works when the owner no longer exists and the behavior is covered by reproducible steps and tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authorization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100