google / google/site-kit-wp

No option to reset sharing permissions or recover a module if owner no longer exists

Open
#9,617 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Module: Analytics Type: Bug Type: Support
Dominant language
JavaScript
Stars
1.4k
Forks
384
Avg merge
4d 14h
Merged PRs (30d)
77

Description

Bug Description

When performing some Dashboard Sharing checks, I ran into an issue whereby if one administrator who the module owner no longer exists, module recovery no longer occurs. This occurred when the Google account associated with module owner (which was a secondary administrator user) may have been used at some stage as the primary user (ie. The primary user/Site Kit owner, was changed by disconnecting and connecting once more).

Further testing ongoing, with steps to reproduce to be added.

Image

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Additional Context

  • SK 1.139.0
  • Potential bug, discovered during testing related to a support topic
  • UPDATE: Reset sharing permissions does appear if you apply DS sharing options for other modules. This however, can't be used as a workaround as resetting will only reset modules owner by the user resetting.

Image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the problem through the Dashboard Sharing checks described in the issue, using the reported Site Kit 1.139.0 setup with a deleted module owner. Trace the module recovery and reset-sharing-permissions paths; done means recovery works when the owner no longer exists and the behavior is covered by reproducible steps and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.