google / google/site-kit-wp

Update the "insufficient permissions" modals to display the second sentence on a separate line.

Open
#9,004 1 comment 0 reactions 0 assignees View on GitHub
Feature: Audiences Module: Analytics P2 Type: Enhancement
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

As discussed on [Figma](https://www.figma.com/design/7pSrkEy8t00BcYRAi9LjjH?node-id=1890-23292#870963163), we should update the main "Additional Permissions Required" and the Audience Segmentation "Insufficient permissions" error modal so the text "Trouble getting access?" starts on a new line.

Here's how the ["Additional Permissions Required" modal](https://google.github.io/site-kit-wp/storybook/develop/?path=/story/components-authenticatedpermissionsmodal--default) currently looks:
![image](https://github.com/google/site-kit-wp/assets/18395600/644bd5e8-a10a-44f4-a2f7-84bcfb976f36)

And here's the [Audience Segmentation "Insufficient permissions" error modal](https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-analytics4-components-audiencesegmentation-dashboard-audienceerrormodal--with-insufficient-permissions-error):
![image](https://github.com/google/site-kit-wp/assets/18395600/d04aaa43-6eec-4c61-af1f-ad8f4cc5e9f0)

The Audience Segmentation modal should be updated with the text on a new line as seen in [Figma](https://www.figma.com/design/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?node-id=1890-23292&t=aO7vzOicIBu2qZ25-0).:
![image](https://github.com/google/site-kit-wp/assets/18395600/254e9fc2-bdef-446e-ab71-3a8b1064b785)

The "Additional Permissions Required" modal doesn't have a Figma design to refer to but should be updated along the same lines.

Please note that when updating the Audience Segmentation modal it's not expected for the modal to precisely match Figma, as discussed on this [Figma thread](https://www.figma.com/design/7pSrkEy8t00BcYRAi9LjjH?node-id=1890-23073#870956365). This issue should only be scoped to the line break aspect.

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start from the Storybook entries for the Authenticated Permissions Modal and the Audience Segmentation insufficient-permissions error modal linked in the issue. Review how each modal displays its message, then verify that “Trouble getting access?” begins on a separate line in both stories and that the scope remains limited to the line break.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.