google / google/site-kit-wp

Explore More Elegant Solution For Re-Focusing The First Input In Audience Selection Panel

Open
#8,968 8 comments 0 reactions 0 assignees View on GitHub
Feature: Audiences P2 Type: Enhancement
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 12h
Merged PRs (30d)
80

Description

## Feature Description

Currently when audience sync action is invoked on first panel opening, first input in the panel is not focused afterwards. There is also a preview block, shown before the inputs are loaded, although in my tests focus is lost after re-sync action happens.

Current implementation is in `assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceItems.js` after `TODO` comment

Screenshot 2024-09-17 at 14 08 30

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

* When opening the "Change groups" panel in Audience Selection panel, the selected checkbox (first one) should not lose focus after the available audiences are synced in the background.

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Read the implementation after the TODO in assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceItems.js. Reproduce opening the Change groups panel while audiences sync in the background, then inspect how the preview and inputs affect focus. Done means the selected first checkbox retains focus after syncing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.