google / google/site-kit-wp

Improve awareness of subdomain treatment by AdSense during setup

Open
#8,935 1 comment 0 reactions 1 assignee Claimed by @aaemnnosttv View on GitHub
Language Module: AdSense P2 Type: Enhancement Type: Support UX
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 12h
Merged PRs (30d)
80

Description

## Bug Description

AdSense no longer requires subdomain sites to be approved individually before ads are served, instead using the status of the parent domain ([reference](https://support.google.com/adsense/answer/12170421?hl=en)) for each subdomain. With this change, Site Kit now sends only the top level domain for AdSense approval when a user happens to try and submit a subdomain site for approval (see #8124).

Many users will never be able to get their parent domain approved for ads for various reasons (restrictions, access and ownership, no possibility to place AdSense code on the parent domain. Examples including mysite.instawp.com, mysite.tastewp.com, mysite.wordpress.com. Such users will never be able go "complete" AdSense set up within Site Kit, as the parent domain is not and may never be approved for ads.

To improve the experience and awareness for users, consider one of the following improvements, or something else:

**1. A re-wording of the status messages or the addition of the site URL**

A users parent domain could be listed within [the message shown](https://github.com/google/site-kit-wp/blob/ebed6cd857abf9fe3557fae0057683214dddd5ba/assets/js/modules/adsense/components/settings/utils.js#L104) for all status'

For subdomains an additional message could be displayed (ie. only parent domains can be submitted for review)

![image](https://github.com/google/site-kit-wp/assets/41326532/fd65eccd-af8a-4098-a836-6386fa61b477)

![image](https://github.com/google/site-kit-wp/assets/41326532/6903e9a7-0df8-4f1e-813b-0d95aa16392f)

**2. In the AdSense settings / set up screen, show a permanent message for subdomain sites, similar to the below:**

![image](https://github.com/google/site-kit-wp/assets/41326532/0c4a802d-6f5c-42a2-92ae-166bfd890712)


- Device: [e.g. iPhone6]

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.