google / google/site-kit-wp

Change the wording for users that have approved AdSense accounts, but that particular site not approved

Open
#8,210 0 comments 0 reactions 0 assignees View on GitHub
Module: AdSense Type: Enhancement Type: Support
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Bug Description

If a user who has an approved AdSense account (with multiple sites) tries to connect the AdSense module on a site that is not approved for ads, they'll encounter the below notice:

```
Your account isn’t ready to show ads yet
You need to fix some things before we can connect Site Kit to your AdSense account
```

![image](https://github.com/google/site-kit-wp/assets/41326532/56fbcbe4-54a0-4a98-a78e-7c490265f340)

The issue here isn't the AdSense account, it's that particular site.

Consider changing the wording so it reflects additional scenarious.

```diff
- Your account isn’t ready to show ads yet / You need to fix some things before we can connect Site Kit to your AdSense account
+ Your account or site isn’t ready to show ads yet / You need to fix some things before your site is suitable for ads
```

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start at the AdSense module connection flow that displays the quoted notice and locate the source of its wording. Update the message to cover both account and site readiness, then verify the approved-account and unapproved-site scenario shows the revised text.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.