google / google/site-kit-wp

Review the text within the AdSense settings page when a site hasn't yet been reviewed / approved

Open
#8,075 0 comments 0 reactions 0 assignees View on GitHub
Module: AdSense Type: Enhancement Type: Support
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 12h
Merged PRs (30d)
80

Description

## Bug Description

At present if an AdSense user uses Site Kit to add a new site to AdSense or adds a previously rejected site, the status within the Site Kit settings page will always display a "Your site is getting ready" or "You need to fix some things before we can connect Site Kit to your AdSense account" message respectively.

The second isn't really accurate, as their site is pending an AdSense review. Their site may be approved without any changes.

I have a [recording of this scenario here](https://recordit.co/x5pL8eot3m).

![image](https://github.com/google/site-kit-wp/assets/41326532/fae38616-b604-4a6d-9a47-37ea32ec0407)

A relatively straightforward improvement here, is to change the text as per the below:

```diff
- You need to fix some things before we can connect Site Kit to your AdSense account.
+ Your site has not yet been approved for ads by the AdSense team.
```

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start in the AdSense settings page by searching the codebase for the current “You need to fix some things before we can connect Site Kit to your AdSense account” text. Update the pending-review wording to match the issue and verify the settings page for a newly added or previously rejected site shows the approval message.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.