google / google/site-kit-wp

Improve behavior during AdSense setup when a user's account is Disapproved

Open
#7,963 0 comments 0 reactions 0 assignees View on GitHub
Type: Enhancement Type: Support
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 12h
Merged PRs (30d)
80

Description

## Bug Description

If a user tries to setup AdSense and their account is disapproved, they'll have a "Retry" button available to them. Given their AdSense account is not approved, such a "Retry" button, very rarely (and only with time and a manual check from the AdSense team) will the status change from the time they encounter this button to the time they leave the Site Kit dashboard. This makes the button almost redundant, they can press it endless times without any change.

[Recording of experience](https://www.loom.com/share/06dd8b8cd7e44f8582fd1a148a47196f?sid=efdb041a-d4a8-4c88-b81e-d29d74ba3aea)

[Further testing complete](https://app.asana.com/0/1185360131189553/1205093739394876/f). It's possible to recreate this issue using a 10up email (with AdSense restricted using these accounts)

![image](https://github.com/google/site-kit-wp/assets/41326532/4dd6fcf8-2ddc-4ba0-b259-f1fefa00f85f)

Possible solutions to improve the behavior for users who's account is disapproved:
1. Remove the Retry button
2. Change this to “retry button didn’t work?” message after a first click (should the status not change)
3. Change the Retry button to a "Learn more" button with details to be added on the Site Kit plugin website

## Steps to reproduce

1. Using a Google Wordspace account where AdSense is restricted, or a Google account that has a disapproved AdSense account, set up Site Kit
2. Connect the AdSense module
3. The notice with regards a disapproved account appears

## Screenshots

Network tab screenshots:

![image](https://github.com/google/site-kit-wp/assets/41326532/9f5089fe-7f44-415b-8ae0-929c102731c9)

![image](https://github.com/google/site-kit-wp/assets/41326532/8877b0f5-f931-4fa2-8cfd-bea6ca6226ad)

## Additional Context

- Site Kit 1.115.0

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue using the documented restricted or disapproved AdSense account setup steps, then inspect the notice and the network requests shown in the screenshots. The issue lists three possible behavior changes but does not select one; done requires an agreed Retry or Learn more experience that no longer invites ineffective repeated attempts.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.